Skip to content

Enable Default PSSCript Rules#492

Merged
johlju merged 2 commits intodsccommunity:devfrom
SSvilen:psscriptanalyzer
Aug 26, 2019
Merged

Enable Default PSSCript Rules#492
johlju merged 2 commits intodsccommunity:devfrom
SSvilen:psscriptanalyzer

Conversation

@SSvilen
Copy link
Copy Markdown
Contributor

@SSvilen SSvilen commented Aug 26, 2019

Pull Request (PR) description

I have noticed that the default rules for PSScriptAnalyzer were not enabled, although a bunch of them are part of IncludeRules array.
Adding following line in analyzersettings.psd1 would enable them:
IncludeDefaultRules = $true

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #492 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #492   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        23     23           
  Lines      3065   3065           
  Branches     10     10           
===================================
  Hits       3020   3020           
  Misses       35     35           
  Partials     10     10

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 583704e into dsccommunity:dev Aug 26, 2019
@SSvilen SSvilen deleted the psscriptanalyzer branch August 26, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSScriptAnalyzer: Enable default rules

3 participants