Add support for user function namespace to have underscore prefix #1272
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for user function namespaces to have underscore prefixes, addressing issue #1271. This change accommodates bicep-generated namespaces that may include underscore prefixes.
Key Changes:
- Modified the DSC expression grammar to allow underscores in function namespace identifiers
- Added test coverage for namespace with underscore prefix (
__bicep.myFunction) - Updated existing PowerShell test to use underscore-prefixed namespace
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grammars/tree-sitter-dscexpression/grammar.js | Updated functionName regex to allow underscores in namespace while keeping function names alphanumeric only |
| grammars/tree-sitter-dscexpression/test/corpus/valid_expressions.txt | Added test case for namespace with double underscore prefix |
| dsc/tests/dsc_user_functions.tests.ps1 | Updated test case to use __MyFunction namespace demonstrating the new functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tgauth
approved these changes
Nov 18, 2025
snehanagendra
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
User functions namespace can have underscores prefix as generated from bicep. This fixes the grammar to allow for underscores in the namespace but not the function name.
PR Context
Fix #1271