Add better error handling for 401s

Author: alerickson

src/code/V2ServerAPICalls.cs

@@ -515,18 +515,23 @@ private string HttpRequestCall(string requestUrlV2, out ErrorRecord errRecord)
 
                 response = SendV2RequestAsync(request, _sessionClient).GetAwaiter().GetResult();
             }
-            catch (HttpRequestException e)
+            catch (V3ResourceNotFoundException e)
             {
-                errRecord = new ErrorRecord(e, "HttpRequestFallFailure", ErrorCategory.ConnectionError, this);
+                errRecord = new ErrorRecord(e, "ResourceNotFound", ErrorCategory.InvalidResult, this);
             }
-            catch (ArgumentNullException e)
+            catch (UnauthorizedException e)
             {
-                errRecord = new ErrorRecord(e, "HttpRequestFallFailure", ErrorCategory.ConnectionError, this);
+                errRecord = new ErrorRecord(e, "UnauthorizedRequest", ErrorCategory.InvalidResult, this);
             }
-            catch (InvalidOperationException e)
+            catch (HttpRequestException e)
             {
-                errRecord = new ErrorRecord(e, "HttpRequestFallFailure", ErrorCategory.ConnectionError, this);
+                errRecord = new ErrorRecord(e, "HttpRequestCallFailure", ErrorCategory.ConnectionError, this);
             }
+            catch (Exception e)
+            {
+                errRecord = new ErrorRecord(e, "HttpRequestCallFailure", ErrorCategory.ConnectionError, this);
+            }
+
 
             return response;
         }

src/code/V3ServerAPICalls.cs

@@ -1138,15 +1138,15 @@ private string HttpRequestCall(string requestUrlV3, out ErrorRecord errRecord)
 
                 response = SendV3RequestAsync(request, _sessionClient).GetAwaiter().GetResult();
             }
-            catch (HttpRequestException e)
+            catch (V3ResourceNotFoundException e)
             {
-                errRecord = new ErrorRecord(e, "HttpRequestCallFailure", ErrorCategory.InvalidResult, this);
+                errRecord = new ErrorRecord(e, "ResourceNotFound", ErrorCategory.InvalidResult, this);
             }
-            catch (ArgumentNullException e)
+            catch (UnauthorizedException e)
             {
-                errRecord = new ErrorRecord(e, "HttpRequestCallFailure", ErrorCategory.InvalidResult, this);
+                errRecord = new ErrorRecord(e, "UnauthorizedRequest", ErrorCategory.InvalidResult, this);
             }
-            catch (InvalidOperationException e)
+            catch (HttpRequestException e)
             {
                 errRecord = new ErrorRecord(e, "HttpRequestCallFailure", ErrorCategory.InvalidResult, this);
             }

test/FindPSResourceTests/FindPSResourceV3Server.Tests.ps1

@@ -285,4 +285,13 @@ Describe 'Test HTTP Find-PSResource for V3 Server Protocol' -tags 'CI' {
         $res | Should -Not -BeNullOrEmpty
         $res.Count | Should -BeGreaterThan 300
     }
+
+    It "should throw unauthorized exception if private repository with no credentials" {
+        Register-PSResourceRepository -Name "PrivateGallery" -Uri "https://gitlab.com/api/v4/projects/47456554/packages/nuget/index.json"
+        $res = Find-PSResource -Name $testModuleName -Repository "PrivateGallery" -ErrorVariable err -ErrorAction SilentlyContinue
+        Unregister-PSResourceRepository -Name "PrivateGallery"
+        $res | Should -BeNullOrEmpty
+        $err.Count | Should -BeGreaterThan 0
+        $err[0].FullyQualifiedErrorId | Should -BeExactly "UnauthorizedRequest,Microsoft.PowerShell.PSResourceGet.Cmdlets.FindPSResource"
+    }
 }