Install-PSResource and NuGet v3: Bad folder name created if version string has no build number

[wellis83]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest released version
• Search the existing issues.

Steps to reproduce

Register a v3 feed, then install a module with a version string containing only major and minor versions (e.g. "2.1"):

Register-PSResourceRepository -Name test -Uri https://pwsh.gallery/index.json -Trusted
Install-PSResource SemVerPS -Repository test
Import-Module SemVerPS

This will give an error, because the folder is created as "2.1.0" instead of "2.1":

VERBOSE: Skipping the Version folder 2.1.0 under Module C:\Users\wellis\Documents\PowerShell\Modules\SemVerPS as it does not have a valid module manifest file.
Import-Module: The specified module 'SemVerPS' was not loaded because no valid module file was found in any module directory.

Expected behavior

Module is imported

Actual behavior

Importing module fails.

Error details

Exception             : 
    Type    : System.IO.FileNotFoundException
    Message : The specified module 'SemVerPS' was not loaded because no valid module file was found in any module 
directory.
    HResult : -2147024894
TargetObject          : SemVerPS
CategoryInfo          : ResourceUnavailable: (SemVerPS:String) [Import-Module], FileNotFoundException
FullyQualifiedErrorId : Modules_ModuleNotFound,Microsoft.PowerShell.Commands.ImportModuleCommand
InvocationInfo        : 
    MyCommand        : Import-Module
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 28
    Line             : Import-Module SemVerPS
    Statement        : Import-Module SemVerPS
    PositionMessage  : At line:1 char:1
                       + Import-Module SemVerPS
                       + ~~~~~~~~~~~~~~~~~~~~~~
    InvocationName   : Import-Module
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : 
      0
      1

Environment data

ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     1.2.0      preview4   Microsoft.PowerShell.PSResourceGet  {Compress-PSResource, Find-PSResource, Get-Instal…


Name                           Value
----                           -----
PSVersion                      7.4.13
PSEdition                      Core
GitCommitId                    7.4.13
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

No response

[o-l-a-v]

That module has conflicting version info though.

• PowerShell Gallery GUI says v2.1: https://www.powershellgallery.com/packages/SemVerPS/2.1
• PowerShell Gallery download URL says v2.1.0: https://cdn.powershellgallery.com/packages/semverps.2.1.0.nupkg
• pwsh.gallery says v2.1.0: https://pwsh.gallery/registration/semverps/index.json

When looking at files inside the semverps.2.1.0.nupkg:

• SemVerPS.nuspec says version v2.1.0
• SemVerPS.psd1 says v2.1

---

pwsh.gallery API returns different info than PSGallery

PS C:\Users\olavb> (Find-PSResource -Repository 'pwsh.gallery' -Name 'SemVerPS').Version.ToString()

2.1.0

PS C:\Users\olavb> (Find-PSResource -Repository 'PSGallery' -Name 'SemVerPS').Version.ToString()

2.1

PS C:\Users\olavb>

---

At first glance it looks like a problem with pwsh.gallery. I think PSResourceGet uses the version info from the API for naming the folder.

PSResourceGet could get around it by checking the version in the manifest file *.psd1, and us it if it's different then what the API says. But should it? 🤔 Should it not trust the API?

[wellis83]

Yeah, good point. It seems to me that the real problem lies with the Test-ModuleManifest cmdlet. It appears to be comparing the versions as strings. If it would parse them into e.g. System.Version first, this problem would go away.

[o-l-a-v]

Kind of related: JustinGrote/ModuleFast#3

I don't think pwsh.gallery has a repo where we can create issues anymore, the old one is archived:

• https://github.com/JustinGrote/PWSHGallery