Fix PSModuleInfo property deserialization in ValidateModuleManifest #1909
+37
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed PowerShell.Create() to PowerShell.Create(RunspaceMode.CurrentRunspace) in Utils.ValidateModuleManifest() to prevent property deserialization issues when crossing runspace boundaries. Added test case to verify the fix. Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix empty Author string in PSModuleInfo
Fix PSModuleInfo property deserialization in ValidateModuleManifest
Nov 18, 2025
Copilot finished work on behalf of
adityapatwardhan
November 18, 2025 20:19
adityapatwardhan
approved these changes
Nov 18, 2025
adityapatwardhan
requested review from
SydneyhSmith,
alerickson,
anamnavi and
shammu1
as code owners
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@copilot in the file Utils.cs after the change in the previous commit, do not check whether pwsh.HadErrors. Instead do the subsequent checks on the result object. |
…dErrors first Changed validation logic to check Author, Description, and Version properties on the result object directly, rather than only checking them when pwsh.HadErrors is true. This ensures proper validation with CurrentRunspace mode. Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Contributor
Author
Done. Changed the validation logic to check Author, Description, and Version properties directly on the result object, rather than only when Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
adityapatwardhan
November 19, 2025 19:20
alerickson
approved these changes
Nov 20, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Utils.ValidateModuleManifest()fails with false positive "No author was provided" errors becausePSModuleInfoproperties return empty strings when deserialized across runspace boundaries.PR Context
PowerShell.Create()instantiates a new runspace. Objects returned from cmdlets executed in that runspace are serialized when crossing back to the calling context. During this serialization/deserialization,PSModuleInfoproperties (Author,Description,Version) lose their values.Changes:
src/code/Utils.cs(line 1378): UsePowerShell.Create(RunspaceMode.CurrentRunspace)instead ofPowerShell.Create()src/code/Utils.cs(lines 1403-1430): Restructured validation logic to check PSModuleInfo properties directly on the result object, regardless ofpwsh.HadErrorsstatetest/PublishPSResourceTests/PublishPSResource.Tests.ps1: Add test case validating manifest validation without-SkipModuleManifestValidateBefore:
After:
Running
Test-ModuleManifestin the current runspace eliminates the serialization boundary, preserving object properties. The validation logic now checks properties directly on the result object rather than only whenpwsh.HadErrorsis true, ensuring proper validation with CurrentRunspace mode.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.Original prompt
This section details on the original issue you should resolve
<issue_title>Bug: PSModuleInfo.Author returns empty string when called via PowerShell Runspace</issue_title>
<issue_description>## 🐛 Bug Description
Utils.ValidateModuleManifest()fails with false positive "No author was provided" error when called via[PowerShell]::Create()runspace, even though the module manifest contains a validAuthorfield.The issue occurs because PSModuleInfo.Author property returns empty string when the object is deserialized across PowerShell runspace boundary.
📍 Affected Code
File:
src/code/Utils.csLines: 1388-1403
🔬 Root Cause
PSModuleInfo property deserialization fails when object crosses PowerShell runspace boundary.
Test Case 1: Direct Call (Works ✅)
Test Case 2: Runspace Call (Fails ❌)
Comparison Table:
Test-ModuleManifest -Path'GrexyLoco'[PowerShell]::Create()''(empty)False💥 Impact
Symptom:
Publish-PSResourcethrows error:Workaround Required:
This forces users to bypass validation entirely, which is not ideal for catching actual manifest issues.
🔧 Suggested Fix
Option 1: Use direct Test-ModuleManifest call (preferred)
Option 2: Serialize specific properties explicitly
Option 3: Add null/empty check with better error message
🧪 Reproduction Steps
Author = 'TestAuthor'Publish-PSResource -Path ./Module -Repository MyRepoTest-ModuleManifest→ works correctly📋 Environment
.psd1with all required fields includingAuthor📎 References
✅ Expected Behavior
ValidateModuleManifest()should correctly readAuthorproperty from module manifest regardless of execution context (direct vs runspace).❌ Actual Behavior
Authorproperty returns empty stri...💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.