Skip to content

Conversation

@zloeber
Copy link
Contributor

@zloeber zloeber commented May 5, 2017

Additional capability for new-plastermanifest that allows both parameters and content to be passed into the function as part of the manifest creation process. This is independent from the 'addcontent' switch as it allows custom strings to be passed in rather than looking for existing xml files. Added additional pester tests to account for the new parameters as well.

zloeber added 2 commits May 5, 2017 09:09
…Manifest. Added addition pester test for this scenario. Changed > $null to be $null = in new-plastermanifest as well.
@zloeber
Copy link
Contributor Author

zloeber commented Jun 18, 2017

Is this travis integration new? I'm not certain how to rectify this build failure.

@daviwil
Copy link
Contributor

daviwil commented Jun 18, 2017

The Travis build does nothing at the moment, don't worry about it :) I probably shouldn't have turned it on so hastily, I'll turn it back off until we're actually using it.

@PowerSchill
Copy link

You can set it up so that it won't attempt the travis build until we actually have a travis config in the repo.

@justin-p
Copy link

Hi @daviwil, is there anything preventing this PR form being merged ? If so i would love to take a stab at it.

@rkeithhill
Copy link
Collaborator

@justin-p David is off working on other things for GitHub (last I heard). This PR I don't quite get because I'm not sure why you'd want to specify the input to this command using strings containing XML? You can already add that XML to the generated manifest. I would think that a PowerShell might prefer to do this instead:

New-PlasterManifest ... -AddParameter @{name="ModuleName"; type="text"; prompt="Enter the name of the module. No space, underscores, or special characters are allowed"},@{...}

And for files, perhaps:

$files = Get-ChildItem .\staging -r -file
New-PlasterManifest ... -AddFile $files

@justin-p
Copy link

Hi @rkeithhill, yeah I get what you mean. Just created a Draft PR that gives the same end result this PR gives only in a more 'PowerShelly'-way.

@psjamesp psjamesp closed this Apr 30, 2022
@psjamesp
Copy link
Contributor

Not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants