-
Notifications
You must be signed in to change notification settings - Fork 116
Zloeberdev2 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zloeberdev2 #254
Conversation
…Manifest. Added addition pester test for this scenario. Changed > $null to be $null = in new-plastermanifest as well.
|
Is this travis integration new? I'm not certain how to rectify this build failure. |
|
The Travis build does nothing at the moment, don't worry about it :) I probably shouldn't have turned it on so hastily, I'll turn it back off until we're actually using it. |
|
You can set it up so that it won't attempt the travis build until we actually have a travis config in the repo. |
|
Hi @daviwil, is there anything preventing this PR form being merged ? If so i would love to take a stab at it. |
|
@justin-p David is off working on other things for GitHub (last I heard). This PR I don't quite get because I'm not sure why you'd want to specify the input to this command using strings containing XML? You can already add that XML to the generated manifest. I would think that a PowerShell might prefer to do this instead: New-PlasterManifest ... -AddParameter @{name="ModuleName"; type="text"; prompt="Enter the name of the module. No space, underscores, or special characters are allowed"},@{...}And for files, perhaps: |
|
Hi @rkeithhill, yeah I get what you mean. Just created a Draft PR that gives the same end result this PR gives only in a more 'PowerShelly'-way. |
|
Not needed |
Additional capability for new-plastermanifest that allows both parameters and content to be passed into the function as part of the manifest creation process. This is independent from the 'addcontent' switch as it allows custom strings to be passed in rather than looking for existing xml files. Added additional pester tests to account for the new parameters as well.