Skip to content

Update about_Hash_Tables.md#1065

Merged
zjalexander merged 2 commits intostagingfrom
SteveL-MSFT-patch-1
Feb 24, 2017
Merged

Update about_Hash_Tables.md#1065
zjalexander merged 2 commits intostagingfrom
SteveL-MSFT-patch-1

Conversation

@SteveL-MSFT
Copy link
Contributor

@SteveL-MSFT SteveL-MSFT commented Feb 22, 2017

Added lines to help where a key name of keys collides with the keys property

Version(s) of document impacted

  • Impacts 5.1 document
  • Impacts 5.0 document
  • Impacts 4.0 document
  • Impacts 3.0 document

Reason(s) for not updating all version of documents

  • The docuemnted feature was introduced in selected version (list version(s) here) of PowerShell
  • This issue only shows up in selected version (list version(s) here) of the document
  • This PR partially fixes the issue, and issue # tracks the remaining work

Added lines to help where a key name of `keys` collides with the keys property
@saldana
Copy link
Contributor

saldana commented Feb 22, 2017

✅ Validation status: passed

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@SteveL-MSFT
Copy link
Contributor Author

Updated description to be more generic and not just about keys based on feedback

@saldana
Copy link
Contributor

saldana commented Feb 22, 2017

✅ Validation status: passed

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@zjalexander
Copy link
Contributor

zjalexander commented Feb 23, 2017

Can I bother you about a few more things in this file since you're in here anyway? :)

key\/value 
Use an equal sign (\=) 

it looks like the slash is escaped, which shows up inconsistently on the web help but shows up correctly in get-help. Do you know if the escape is truly necessary for get-help?

Also, the last 3 links in the "See Also" section are broken. Would you mind fixing those as well?

If not, I'll just file an issue and get to it at some point.

Otherwise, this change looks fine to me.

@SteveL-MSFT
Copy link
Contributor Author

@zjalexander I don't know if the escape character is needed. I'd suggest filing issues for the broken links. I was specifically addressing PowerShell/PowerShell#3176

@zjalexander
Copy link
Contributor

#1074 opened

@zjalexander zjalexander merged commit 889f2aa into staging Feb 24, 2017
@andyleejordan andyleejordan removed the in-progress Tag - issue is being worked on by someone label Feb 24, 2017
@HemantMahawar HemantMahawar deleted the SteveL-MSFT-patch-1 branch February 24, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants