-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix Out-String according to the Contributor Guide #2759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Validation status: errors
reference/6/Microsoft.PowerShell.Utility/Out-String.md
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example #2 breaks the PlatyPS schema. Need to reformat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the same changes to 3/4/5.0/6.0 to keep the files consistent.
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Could you look at the Related Links section? They are not the same for all versions (3.0-6). Also, this cmdlets could output two different types-- a string and an array of strings (depends of the -Stream parameter). Should that be mentioned in the Outputs section? |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
@alexandair I fixed the related links in this PR. I removed the links to the cmdlets not included in v6. Also, whenever you see fully qualified links like that, you should fix the links to use the relative paths to the file per the style guide. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Change a description for the Width parameter.
Remove "Windows" from "Windows PowerShell".
Simplify prompt to
PS>.Change a formatting of cmdlet, variable, parameter, and property names.
Use semantic line breaks.
Fix fenced code blocks.
Version(s) of document impacted
Reason(s) for not updating all version of documents