Terminal not interpreting ascii control characters after certain git commands

[AvrumFeldman]

Issue Type: Bug

System Details

• git 2.21.0.windows.1
• VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:49:35.976Z)
• VScode Powershell extension version: 2019.11.0
• OS version: Windows_NT x64 10.0.17763

Issue Description

Certain git commands cause the integrated console to stop parsing control characters. Getting ? mark instead.
Restarting the console solves the issue until next git command.

Steps to Reproduce:

1. In the integrated terminal type [char]27 (ascii escape character).
2. Run a git push.
3. Try again to type out the ascii escape character using [char]27.

Notes:

• Issue doesn't happen when using regular powershell terminal. (within vscode nor external one)

ScreenShot

[TylerLeonhardt]

@AvrumFocus does this only repro in the Integrated Console? Can you try this repro in the the Integrated Terminal or outside of vscode?

[AvrumFeldman]

@TylerLeonhardt The issue only happens in the integrated console, using the integrated terminal or the terminal not in vscode it doesn't happen. As you can see in the attached gif.

[TylerLeonhardt]

@AvrumFocus you deleted a comment with it working in the Integrated Console. Any reason you deleted that?

[AvrumFeldman]

@TylerLeonhardt I deleted it because I just tested on the original computer with an updated version of git plus reinstalled cleanly vscode and the issue was still there.

[rjmholt]

@AvrumFocus would you be able to record the output of the following before and after the git invocation causing this issue:

chcp
$OutputEncoding
[System.Console]::OutputEncoding

[AvrumFeldman]

Before

Active code page: 437

IsSingleByte : True
BodyName : us-ascii
EncodingName : US-ASCII
HeaderName : us-ascii
WebName : us-ascii
WindowsCodePage : 1252
IsBrowserDisplay : False
IsBrowserSave : False
IsMailNewsDisplay : True
IsMailNewsSave : True
EncoderFallback : System.Text.EncoderReplacementFallback
DecoderFallback : System.Text.DecoderReplacementFallback
IsReadOnly : True
CodePage : 20127

BodyName : utf-8
EncodingName : Unicode (UTF-8)
HeaderName : utf-8
WebName : utf-8
WindowsCodePage : 1200
IsBrowserDisplay : True
IsBrowserSave : True
IsMailNewsDisplay : True
IsMailNewsSave : True
IsSingleByte : False
EncoderFallback : System.Text.EncoderReplacementFallback
DecoderFallback : System.Text.DecoderReplacementFallback
IsReadOnly : False
CodePage : 65001

After

Active code page: 437

IsSingleByte : True
BodyName : us-ascii
EncodingName : US-ASCII
HeaderName : us-ascii
WebName : us-ascii
WindowsCodePage : 1252
IsBrowserDisplay : False
IsBrowserSave : False
IsMailNewsDisplay : True
IsMailNewsSave : True
EncoderFallback : System.Text.EncoderReplacementFallback
DecoderFallback : System.Text.DecoderReplacementFallback
IsReadOnly : True
CodePage : 20127

BodyName : utf-8
EncodingName : Unicode (UTF-8)
HeaderName : utf-8
WebName : utf-8
WindowsCodePage : 1200
IsBrowserDisplay : True
IsBrowserSave : True
IsMailNewsDisplay : True
IsMailNewsSave : True
IsSingleByte : False
EncoderFallback : System.Text.EncoderReplacementFallback
DecoderFallback : System.Text.DecoderReplacementFallback
IsReadOnly : False
CodePage : 65001

Note

If I'm correct, the encoding shouldn't make a difference on character 27 as the only place there started to be discrepancies between encoding was from char 127 and up (7 bits)

[SydneyhSmith]

@AvrumFocus do you have anything (like posh git) that is set up to interact with git? Also would be great to know if you have anything in your profile or prompt function--thanks for all the info so far!

[SydneyhSmith]

Also would be great to know if you are able to reproduce this in the PowerShell preview extension--thanks!

[AvrumFeldman]

@AvrumFocus do you have anything (like posh git) that is set up to interact with git? Also would be great to know if you have anything in your profile or prompt function--thanks for all the info so far!

Nope, no powershell modules and using default powershell prompt.

About the Posh-git: I even went now and installed it to see if that would maybe fix the issue, unfortunately it didn't.

Also would be great to know if you are able to reproduce this in the PowerShell preview extension--thanks!

Same result.

I will spin up a new VM next week with just git and vscode to see if there is something in my environment that might be causing it.

[AvrumFeldman]

Update: I installed the preview version of the powershell extension and noticed that the issue partially disappears. Partially meaning, the first prompt after the git command still does not read correctly the ascii command, but once I press enter and get another prompt the ascii command starts working again.