Skip to content

fix: improve error handling in token refresh endpoint and simplify ex… #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

fix: improve error handling in token refresh endpoint and simplify ex… #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions flamesdk/resources/rest_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,14 @@ def __init__(self,
self.finishing_call = finishing_call

@router.post("/token_refresh", response_class=JSONResponse)
async def token_refresh(request: Request) -> Optional[JSONResponse]:
async def token_refresh(request: Request) -> JSONResponse:
try:
# get body
body = await request.json()
new_token = body.get("token")
if not new_token:
try:
raise HTTPException(status_code=400, detail="Token is required")
except HTTPException as e:
self.flame_logger.raise_error(f"No token, raising HTTPException: {repr(e)}")
self.flame_logger.raise_error(f"No token provided for refresh")
raise HTTPException(status_code=400, detail="Token is required")

# refresh token in po client
po_client.refresh_token(new_token)
Expand All @@ -73,10 +71,8 @@ async def token_refresh(request: Request) -> Optional[JSONResponse]:
self.keycloak_token = new_token
return JSONResponse(content={"message": "Token refreshed successfully"})
except Exception as e:
try:
raise HTTPException(status_code=500, detail=str(e))
except HTTPException as e:
self.flame_logger.raise_error(f"stack trace {repr(e)}")
self.flame_logger.raise_error(f"stack trace {repr(e)}")
raise HTTPException(status_code=500, detail=str(e))

@router.get("/healthz", response_class=JSONResponse)
def health() -> dict[str, Union[str, int]]:
Expand Down