Skip to content

Cross cutting/auth #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChienNQuang merged 17 commits into from
May 26, 2023
Merged

Cross cutting/auth #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
934c0f2
feat: auth with refresh token and jwe using cookies scheme
ChienNQuang May 24, 2023
7391d8e
Merge branch 'dev' into cross-cutting/auth
ChienNQuang May 24, 2023
84fbc73
feat: log out
ChienNQuang May 25, 2023
7b99de4
add: data seed
ChienNQuang May 25, 2023
c21ba97
add: validate endpoint
ChienNQuang May 25, 2023
3b3d946
Merge branch 'dev' into cross-cutting/auth
ChienNQuang May 25, 2023
ddb148a
refactor: change implementation to removing cookies
ChienNQuang May 25, 2023
fad3a3a
fix: disable command not handle all cases and refactor something
ChienNQuang May 25, 2023
8ac3e4f
add: seed env
ChienNQuang May 25, 2023
b6298bd
add: allow credentials
ChienNQuang May 26, 2023
fa1a971
update: origin localhost 3000 on dev
ChienNQuang May 26, 2023
a27c669
fix: revert to any origin
ChienNQuang May 26, 2023
ae76896
fix: revert to local 3000
ChienNQuang May 26, 2023
3262819
fix: refresh endpoint no need to be authorized
ChienNQuang May 26, 2023
13a3d8d
chore: merge from dev
ChienNQuang May 26, 2023
067040a
update: authentication exception now return 400 instead of 401
ChienNQuang May 26, 2023
bf2420b
Merge branch 'dev' into cross-cutting/auth
ChienNQuang May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Api/Middlewares/ExceptionMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ private async void HandleLimitExceededException(HttpContext context, Exception e

private async void HandleAuthenticationException(HttpContext context, Exception ex)
{
context.Response.StatusCode = StatusCodes.Status401Unauthorized;
context.Response.StatusCode = StatusCodes.Status400BadRequest;
await WriteExceptionMessageAsync(context, ex);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Api/appsettings.Development.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"JweSettings": {
"SigningKeyId": "4bd28be8eac5414fb01c5cbe343b50144bd28be8eac5414fb01c5cbe343b50144bd28be8eac5414fb01c5cbe343b50144bd28be8eac5414fb01c5cbe343b50144bd28be8eac5414fb01c5cbe343b5014",
"EncryptionKeyId": "4bd28be8eac5414fb01c5cbe343b5014",
"TokenLifetime": "00:00:05",
"TokenLifetime": "00:20:00",
"RefreshTokenLifetimeInDays": 3
},
"Seed": true,
Expand Down
11 changes: 0 additions & 11 deletions src/Infrastructure/Identity/IdentityService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,6 @@ public async Task<AuthenticationResult> RefreshTokenAsync(string token, string r
{
throw new AuthenticationException("Invalid token.");
}

var expiryDateUnix =
long.Parse(validatedToken.Claims.Single(x => x.Type.Equals(JwtRegisteredClaimNames.Exp)).Value);

var expiryDateTimeUtc = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc)
.AddSeconds(expiryDateUnix);

if (expiryDateTimeUtc > DateTime.UtcNow)
{
throw new AuthenticationException("This token has not expired yet.");
}

var jti = validatedToken.Claims.Single(x => x.Type.Equals(JwtRegisteredClaimNames.Jti)).Value;
var storedRefreshToken = await _context.RefreshTokens.SingleOrDefaultAsync(x => x.Token.Equals(Guid.Parse(refreshToken)));
Expand Down