Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ CUSTOM_EXECUTORS=false
CACHE_SETTING_DRIVER=cache_settings
CACHE_SETTING_PREFIX=settings:
AI_ENABLE_RAG_COLLECTIONS=false
AI_ENABLE_AGENTS=false
3 changes: 2 additions & 1 deletion ProcessMaker/Http/Kernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class Kernel extends HttpKernel
\Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
Middleware\TrimStrings::class,
\Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
Middleware\TrustHosts::class,
Middleware\TrustProxies::class,
Middleware\BrowserCache::class,
ServerTimingMiddleware::class,
Expand Down Expand Up @@ -87,7 +88,7 @@ class Kernel extends HttpKernel
'no-cache' => Middleware\NoCache::class,
'admin' => Middleware\IsAdmin::class,
'etag' => Middleware\Etag\HandleEtag::class,
'file_size_check' => Middleware\FileSizeCheck::class,
'file_size_check' => Middleware\FileSizeCheck::class
];

/**
Expand Down
39 changes: 39 additions & 0 deletions ProcessMaker/Http/Middleware/TrustHosts.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php

namespace ProcessMaker\Http\Middleware;

use Illuminate\Http\Middleware\TrustHosts as Middleware;
use Closure;
use Illuminate\Http\Request;

class TrustHosts extends Middleware
{
public function hosts(): array
{
$trustedHost = $this->allSubdomainsOfApplicationUrl();
return [$trustedHost];
}

public function handle(Request $request, $next)
{
if ($request->hasHeader('X-Forwarded-Host')) {
$forwardedHost = $request->header('X-Forwarded-Host');
$trustedPattern = $this->allSubdomainsOfApplicationUrl();

if (!$this->hostIsValid($forwardedHost, $trustedPattern)) {
\Log::warning('Rejected request with untrusted X-Forwarded-Host', [
'forwarded_host' => $forwardedHost,
'trusted_pattern' => $trustedPattern
]);
abort(400, 'Invalid Host Header');
}
}

return parent::handle($request, $next);
}

protected function hostIsValid(string $host, string $pattern): bool
{
return preg_match('/' . str_replace('/', '\/', $pattern) . '/', $host) === 1;
}
}
61 changes: 61 additions & 0 deletions tests/Feature/Http/Middleware/TrustHostsTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?php

namespace Tests\Feature\Http\Middleware;

use Tests\TestCase;
use ProcessMaker\Http\Middleware\TrustHosts;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Config;

class TrustHostsTest extends TestCase
{
protected $middleware;

protected function setUp(): void
{
parent::setUp();
$this->middleware = new TrustHosts($this->app);
}

public function test_valid_trusted_host()
{
// Set app URL for testing
Config::set('app.url', 'https://example.processmaker.net');

$request = Request::create('https://subdomain.example.processmaker.net');
$request->headers->set('X-Forwarded-Host', 'subdomain.example.processmaker.net');

$response = $this->middleware->handle($request, function ($req) {
return response()->json(['status' => 'success']);
});

$this->assertEquals(200, $response->status());
}

public function test_invalid_trusted_host()
{
// Set app URL for testing
Config::set('app.url', 'https://example.processmaker.net');

$request = Request::create('https://malicious-site.com');
$request->headers->set('X-Forwarded-Host', 'malicious-site.com');

$this->expectException(\Symfony\Component\HttpKernel\Exception\HttpException::class);
$this->expectExceptionMessage('Invalid Host Header');

$this->middleware->handle($request, function ($req) {
return response()->json(['status' => 'success']);
});
}

public function test_missing_forwarded_host()
{
$request = Request::create('https://example.processmaker.net');

$response = $this->middleware->handle($request, function ($req) {
return response()->json(['status' => 'success']);
});

$this->assertEquals(200, $response->status());
}
}