Skip to content

Conversation

@eiresendez
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:

  • The documents uploaded should be shown correctly on the File Upload UI.

Actual behavior:

  • When we upload documents inside a loop control that at the same time this loop is inside a record list, on the next task it will not be visible or the first document will be visible twice.

Solution

The issue was related to:

  1. The query.options.row_id property for new items in the loop was generated with NULL value. This was fixed from the form-recordlist.vue file.
  2. The query.options.data_name property was generated with incorrect values. This was fixed by commenting out the checkIfInRecordList function.

How to Test

  • Import the process 26955.json attached in JIRA
  • Run a new request
  • Add new records in record list
  • Upload documents on the loop control
    • You can override the same file
    • Delete an item from the loop
    • Add more items and files within the loop.
    • Add another record in Record List and repeat

The files must be saved and/or deleted correctly in storage/app/public backend. When submitting the task, everything should be displayed correctly and the files can be downloaded.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants