General Update #22
Merged
General Update #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strflightmight09
approved these changes
Dec 15, 2024
levyishai
requested changes
Dec 16, 2024
src/main/java/org/trigon/hardware/rev/spark/io/SimulationSparkIO.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 18, 2024
src/main/java/org/trigon/commands/GearRatioCalculationCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/org/trigon/commands/GearRatioCalculationCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/org/trigon/commands/GearRatioCalculationCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/main/java/org/trigon/commands/WheelRadiusCharacterizationCommand.java: Evaluated as low risk
- src/main/java/org/trigon/hardware/BaseInputs.java: Evaluated as low risk
Strflightmight09
requested changes
Dec 24, 2024
src/main/java/org/trigon/hardware/rev/spark/io/SimulationSparkIO.java
Outdated
Show resolved
Hide resolved
levyishai
approved these changes
Dec 25, 2024
|
@Strflightmight09 please cr |
Strflightmight09
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.