Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Evaluate the performance of generative models (realism and diversity) #227

Merged
merged 8 commits into from
May 2, 2023
Merged

Evaluate the performance of generative models (realism and diversity) #227

merged 8 commits into from
May 2, 2023

Conversation

JessyD
Copy link
Member

@JessyD JessyD commented Feb 5, 2023

Fix #109

@JessyD JessyD added the need reviewer This PR need a reviewer label May 2, 2023
@JessyD JessyD marked this pull request as ready for review May 2, 2023 13:42
Warvito
Warvito suggested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@Warvito Warvito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few typos and it is necessary to fix the diversity computation. A script that might be useful is available here https://github.com/Warvito/generative_chestxray/blob/main/src/python/testing/compute_msssim_sample.py

@Warvito Warvito requested a review from marksgraham May 2, 2023 14:45
@Warvito
Copy link
Collaborator

Warvito commented May 2, 2023

Hi @marksgraham, I saw that you are reviewing this, but I left a few comments too. I hope it is okay

@JessyD JessyD requested a review from Warvito May 2, 2023 19:32
Warvito
Warvito suggested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@Warvito Warvito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there is just a few points that I forgot to comment. Besides that, please, execute ./runtests.sh --autofix to fix the format of the code.

@JessyD JessyD requested a review from Warvito May 2, 2023 20:32
@Warvito Warvito removed the need reviewer This PR need a reviewer label May 2, 2023
@Warvito Warvito merged commit 639b6eb into main May 2, 2023
@Warvito Warvito deleted the 109-realism-diversity-metrics branch May 4, 2023 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marksgraham marksgraham Awaiting requested review from marksgraham

1 more reviewer

@Warvito Warvito Warvito approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tutorial evaluating the performance of Generative model regarding realism and diversity

2 participants

@JessyD @Warvito