Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Conversation

Warvito
Copy link
Collaborator

@Warvito Warvito commented May 2, 2023

Fixes #381

Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito linked an issue May 2, 2023 that may be closed by this pull request
@Warvito Warvito added the need reviewer This PR need a reviewer label May 2, 2023
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had a few minor suggestions only.

Warvito and others added 3 commits May 3, 2023 14:02
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito merged commit 60a3851 into main May 3, 2023
@Warvito Warvito deleted the 381-remove-assert-in-code branch May 4, 2023 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

need reviewer This PR need a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove assert in code

2 participants