This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Addition of non_quantized flag to enable non-quantised encoding for L… #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DM training on the VQVAE.
marksgraham
reviewed
Mar 12, 2024
generative/networks/nets/vqvae.py
Outdated
| return reconstruction, quantization_losses | ||
|
|
||
| def encode_stage_2_inputs(self, x: torch.Tensor) -> torch.Tensor: | ||
| def encode_stage_2_inputs(self, x: torch.Tensor, non_quantized: bool = False) -> torch.Tensor: |
Collaborator
There was a problem hiding this comment.
can we flip the argument name to quantized and default it to True? I think it's easier to understand then the double-negative non_quantized defaulting to False
marksgraham
suggested changes
Mar 12, 2024
Collaborator
marksgraham
left a comment
marksgraham
left a comment
There was a problem hiding this comment.
Just one request other all good!
Default true.
Contributor
Author
|
Done @marksgraham |
marksgraham
approved these changes
Mar 12, 2024
marksgraham
deleted the
473-allow-ldm-model-to-train-on-non-quantized-encoded-outputs-of-the-vq-vae
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DM training on the VQVAE.