Skip to content

Conversation

@madil90
Copy link
Contributor

@madil90 madil90 commented Jun 16, 2021

Fixes #2381 .

Description

Adds the action for launching jobs when a '/build' comment is posted by an authorized user. This CI job launches pre-merge tests using NVIDIA's blossom CI system.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@madil90 madil90 added the CI/CD label Jun 16, 2021
@madil90 madil90 requested review from Nic-Ma and wyli June 16, 2021 22:29
@madil90 madil90 self-assigned this Jun 16, 2021
Signed-off-by: Mohammad Adil <madil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Jun 17, 2021

@madil90
Copy link
Contributor Author

madil90 commented Jun 17, 2021

  • The requirement to comment '/build' is from Blossom team. We can switch to label based system after discussing with them.
  • Added the concurrency change
  • Yes the checkout has been tested on a fork of MONAI and works with PRs properly.

@wyli
Copy link
Contributor

wyli commented Jun 18, 2021

@wyli wyli added bug Something isn't working and removed bug Something isn't working labels Jun 18, 2021
@wyli wyli requested a review from monai-bot June 18, 2021 15:18
Signed-off-by: Mohammad Adil <madil@nvidia.com>
@madil90
Copy link
Contributor Author

madil90 commented Jun 21, 2021

@wyli signed.

@wyli wyli changed the title Add blossom pre-merge pipeline Add blossom pre-merge pipeline (21/June) Jun 21, 2021
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) June 21, 2021 18:20
@wyli wyli merged commit fb7d9f1 into dev Jun 21, 2021
@wyli wyli deleted the blossom_ci branch June 21, 2021 21:05
@deepib deepib changed the title Add blossom pre-merge pipeline (21/June) Add blossom pre-merge pipeline (1/July) Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pre-merge pipeline using NVIDIA blossom system (7/July)

3 participants