Skip to content

2418 Fix mypy errors caused by numpy(1.21.0) #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 22, 2021
Merged

2418 Fix mypy errors caused by numpy(1.21.0) #2419

merged 7 commits into from
Jun 22, 2021

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jun 22, 2021 •
edited
Loading

Fixes #2418 .

Description

This PR fixed the new mypy issues caused by numpy update.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 7 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #32 from Project-MONAI/master
cd16a13 
merge master
@Nic-Ma
Merge pull request #142 from Project-MONAI/dev
5ba3b41 
merge master
@Nic-Ma
[DLMED] test mypy fix
c2d9da4 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] test commit
6159cc7 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix np.random
174c797 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix other numpy data type errors
071de59 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 22, 2021

/black

@Nic-Ma Nic-Ma changed the title [WIP] 2418 Fix mypy errors caused by numpy(1.21.0) 2418 Fix mypy errors caused by numpy(1.21.0) Jun 22, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review June 22, 2021 17:06
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli June 22, 2021 17:06
wyli
wyli approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 22, 2021 17:15
@Nic-Ma Nic-Ma merged commit 3f452c4 into Project-MONAI:dev Jun 22, 2021
@Nic-Ma Nic-Ma deleted the 2418-fix-numpy-mypy branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New numpy(1.21.0) raised many typehint issues

2 participants

@Nic-Ma @wyli