Make pixelshuffle scriptable
#4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….script` function. Signed-off-by: Ramon Emiliani <ramon@afxmedical.com>
wyli
reviewed
Apr 12, 2022
Signed-off-by: Ramon Emiliani <ramon@afxmedical.com>
Contributor
Author
|
@wyli Seems |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
was going to mention this, I added the condition to skip it MONAI/tests/test_subpixel_upsample.py Line 77 in 026f840 |
Contributor
|
/build |
wyli
approved these changes
Apr 12, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Can-Zhao
added a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
Add padding to filter to ensure same size after anti-aliasing Use replicate padding insteadof zero padding to avoid artifacts for non-zero boundary Reuse GaussianSmooth 4073 Enhance DynUNet doc-strings (Project-MONAI#4102) * Fix doc strings error Signed-off-by: Yiheng Wang <vennw@nvidia.com> * remove duplicate places Signed-off-by: Yiheng Wang <vennw@nvidia.com> 4105 drops pt16 support (Project-MONAI#4106) * update sys req Signed-off-by: Wenqi Li <wenqil@nvidia.com> * temp test Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update code for torch>=1.7 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * temp tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * autofix Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes import Signed-off-by: Wenqi Li <wenqil@nvidia.com> * clear cache Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> * remove temp cmd Signed-off-by: Wenqi Li <wenqil@nvidia.com> Make `pixelshuffle` scriptable (Project-MONAI#4109) * Update the existing functionality to comply with the `torchscript.jit.script` function. Signed-off-by: Ramon Emiliani <ramon@afxmedical.com> meta tensor (Project-MONAI#4077) * meta tensor Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com> 4084 Add kwargs for `Tensor.to()` in engines (Project-MONAI#4112) * [DLMED] add kwargs for to() API Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix typo Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> fixes pytorch version tests (Project-MONAI#4127) Signed-off-by: Wenqi Li <wenqil@nvidia.com> update meta tensor api (Project-MONAI#4131) * update meta tensor api Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update based on comments Signed-off-by: Wenqi Li <wenqil@nvidia.com> runtests.sh isort (Project-MONAI#4134) Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com> update citation (Project-MONAI#4133) Signed-off-by: Wenqi Li <wenqil@nvidia.com> `ToMetaTensor` and `FromMetaTensor` transforms (Project-MONAI#4115) to and from meta no skip if before pytorch 1.7 (Project-MONAI#4139) * no skip if before pytorch 1.7 Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com> * fix Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com> * fix Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com> [DLMED] fix file name in meta (Project-MONAI#4145) Signed-off-by: Nic Ma <nma@nvidia.com> 4116 Add support for advanced args of AMP (Project-MONAI#4132) * [DLMED] fix typo in bundle scripts Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add support for AMP args Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> New wsireader (Project-MONAI#4147) `MetaTensor`: collate; decollate; dataset; dataloader; out=; indexing and iterating across batches (Project-MONAI#4137) `MetaTensor`: collate; decollate; dataset; dataloader; out=; indexing and iterating across batches (Project-MONAI#4137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ramon Emiliani ramon.emiliani@umontreal.ca
Fixes #4108.
Description
Modifies the existing
pixelshufflefunction in such a way that it is scriptable usingtorch.jit.script.Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.