Add OpenSlide support for new WSIReader #4155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Nic-Ma
approved these changes
Apr 21, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me except for some minor comments inline.
Thanks.
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Member
Author
|
@Nic-Ma can you /build here? Thanks |
Contributor
|
/build |
3 similar comments
Contributor
|
/build |
Contributor
|
/build |
Contributor
|
/build |
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
* Implement WSIReader with OpenSlide backend . Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add unittest for openslide Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * formatting Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update imports and few fixes Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Fix x,y in docstrings Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Address comments Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Remove x and y Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4154
Description
This PR implement
OpenSlideWSIReader, which read patches from whole slide images using openslide library in the back.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.