Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Nov 11, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #5510

Description

this makes device and post_func optional

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review November 11, 2022 10:52
@wyli
Copy link
Contributor Author

wyli commented Nov 11, 2022

/build

@wyli wyli enabled auto-merge (squash) November 11, 2022 15:52
@wyli wyli merged commit 89684d6 into Project-MONAI:dev Nov 11, 2022
@wyli wyli deleted the 5510-invert-device branch November 11, 2022 16:35
@myron
Copy link
Collaborator

myron commented Nov 11, 2022

thanks you!

wyli added a commit to Project-MONAI/tutorials that referenced this pull request Nov 15, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Fixes #1041

### Description
issue introduced by Project-MONAI/MONAI#5512

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
bhashemian pushed a commit to bhashemian/MONAI that referenced this pull request Nov 23, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Fixes Project-MONAI#5510

### Description
this makes `device` and `post_func` optional 

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Fixes Project-MONAI#1041

### Description
issue introduced by Project-MONAI/MONAI#5512

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvertD() transform should preserve device of the output

3 participants