Skip to content

Conversation

@Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Jun 8, 2023

Fixes # .

Description

update ldm noise scheduler api for inference

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao Can-Zhao requested a review from yiheng-wang-nv June 8, 2023 16:45
@Can-Zhao Can-Zhao marked this pull request as ready for review June 8, 2023 16:45
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@yiheng-wang-nv
Copy link
Collaborator

yiheng-wang-nv commented Jun 9, 2023

Thanks @Can-Zhao , I will add the unit tests on these 2 bundles within this PR to prevent similar issues.

Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
@yiheng-wang-nv
Copy link
Collaborator

Hi @Nic-Ma , when preparing the unit test of ldm bundles, I just found a place of ldm bundles that is not matched up with:
https://github.com/Project-MONAI/MONAI/blob/e6ec945e4b87b90835cdad29ea64b1f27b8accda/monai/bundle/properties.py#L61

Some datasets may not have "data", such as all datasets in:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/datasets.py
or customized datasets.

Is it possible to change it into BundleProperty.REQUIRED: False ? Or ldm bundles should extend BundleWorkflow directly and define a customized workflow (within the unit test) ?

@Nic-Ma
Copy link
Collaborator

Nic-Ma commented Jun 9, 2023

Hi @yiheng-wang-nv ,

That's a good point, I would suggest to change the required train_dataset_data into BundleProperty.REQUIRED: False in the properties.
CC @SachidanandAlle and @tangy5 .

Thanks.

@yiheng-wang-nv
Copy link
Collaborator

yiheng-wang-nv commented Jun 12, 2023

Hi @yiheng-wang-nv ,

That's a good point, I would suggest to change the required train_dataset_data into BundleProperty.REQUIRED: False in the properties. CC @SachidanandAlle and @tangy5 .

Thanks.

I see. Hi @SachidanandAlle @tangy5 , do you think we can change the "BundleProperty.REQUIRED" of train_dataset_data? Are there any concerns here?

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@YanxuanLiu
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv merged commit c2345c1 into Project-MONAI:dev Jun 13, 2023
yiheng-wang-nv added a commit to yiheng-wang-nv/model-zoo that referenced this pull request Jul 29, 2024
Fixes # .

### Description
update ldm noise scheduler api for inference

### Status
**Ready/Work in progress/Hold**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Co-authored-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
Co-authored-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants