-
Notifications
You must be signed in to change notification settings - Fork 88
update ldm noise scheduler api for inference #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
|
Thanks @Can-Zhao , I will add the unit tests on these 2 bundles within this PR to prevent similar issues. |
Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com>
|
Hi @Nic-Ma , when preparing the unit test of ldm bundles, I just found a place of ldm bundles that is not matched up with: Some datasets may not have "data", such as all datasets in: Is it possible to change it into |
|
Hi @yiheng-wang-nv , That's a good point, I would suggest to change the required Thanks. |
I see. Hi @SachidanandAlle @tangy5 , do you think we can change the "BundleProperty.REQUIRED" of |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
models/brats_mri_axial_slices_generative_diffusion/configs/train_diffusion.json
Show resolved
Hide resolved
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
|
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
|
/build |
Fixes # . ### Description update ldm noise scheduler api for inference ### Status **Ready/Work in progress/Hold** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Can-Zhao <volcanofly@gmail.com> Signed-off-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com> Signed-off-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com> Co-authored-by: Yiheng Wang <vennw@nvidia.com>
Fixes # .
Description
update ldm noise scheduler api for inference
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").