Skip to content

Store & notify HL7 messages #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 15, 2022
Merged

Store & notify HL7 messages #113

merged 8 commits into from
Aug 15, 2022

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Aug 5, 2022 •
edited
Loading

Description

Fixes #102 .

  • Queue incoming HL7 messages for upload & payload assembly.
  • Add new integration test feature for HL7

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Aug 5, 2022
@mocsharp mocsharp added this to the 0.3.0 milestone Aug 5, 2022
@mocsharp mocsharp self-assigned this Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #113 (670835b) into develop (1ef6964) will decrease coverage by 0.10248%.
The diff coverage is 87.60000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #113         +/-   ##
===================================================
- Coverage   92.99690%   92.89442%   -0.10248%     
===================================================
  Files            246         247          +1     
  Lines          13851       13989        +138     
  Branches         732         740          +8     
===================================================
+ Hits           12881       12995        +114     
- Misses           754         777         +23     
- Partials         216         217          +1
Flag Coverage Δ
unittests 92.89442% <87.60000%> (-0.10248%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/CLI/Services/ConfigurationOptionAccessor.cs 3.27869% <0.00000%> (-0.35767%) ⬇️
...ase/Migrations/20220802200605_R3_0.3.0.Designer.cs 100.00000% <ø> (ø)
src/Database/Migrations/20220802200605_R3_0.3.0.cs 66.66667% <ø> (ø)
...grations/InformaticsGatewayContextModelSnapshot.cs 0.00000% <ø> (ø)
...abase/StorageMetadataWrapperEntityConfiguration.cs 100.00000% <ø> (ø)
src/DicomWebClient/DicomWebClient.cs 96.42857% <ø> (ø)
...InformaticsGateway/Services/Common/ITcpListener.cs 0.00000% <ø> (ø)
...ticsGateway/Services/Common/ITcpListenerFactory.cs 0.00000% <ø> (ø)
...icsGateway/Services/Common/NetworkStreamAdapter.cs 0.00000% <ø> (ø)
...rmaticsGateway/Services/Common/TcpClientAdapter.cs 0.00000% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef6964...670835b. Read the comment docs.

Base automatically changed from vchang/temp-storage-service to develop August 8, 2022 18:17
@mocsharp mocsharp force-pushed the vchang/102-hl7-store-message branch from 7c08986 to ae70af7 Compare August 8, 2022 18:21
@mocsharp mocsharp requested a review from a team August 8, 2022 21:26
@mocsharp
gh-102 Queue to upload received HL7 messages & notify payload assembler
ab5ff67 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/102-hl7-store-message branch from 842ef9e to ab5ff67 Compare August 9, 2022 19:02
mocsharp added 4 commits August 9, 2022 17:20
@mocsharp
gh-102 Update CLI to export HL7 port with Docker
d0bb509 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
gh-102 Add new test feature for HL7
145b036 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Fix file header
5e57a83 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Update license scan settings
90cd2a5 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested review from jackschofield23 and removed request for a team August 10, 2022 04:37
mocsharp added 3 commits August 9, 2022 21:46
@mocsharp
gh-102 Include HL7 test feature
9304648 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Fix warnings & update .net project configurations
98bf948 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Fix warnings
670835b 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 2bda3cb into develop Aug 15, 2022
@mocsharp mocsharp deleted the vchang/102-hl7-store-message branch August 15, 2022 17:46
@mocsharp mocsharp modified the milestones: 0.3.0, 0.2.0 Aug 16, 2022
mocsharp added a commit that referenced this pull request Aug 19, 2022
@mocsharp
Store & notify HL7 messages (#113)
b5b4cae 
* gh-102 Queue to upload received HL7 messages & notify payload assembler
* gh-102 Update CLI to export HL7 port with Docker
* gh-102 Add new test feature for HL7
* Update license scan settings

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@github-actions
Copy link

github-actions bot commented Aug 19, 2022

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackschofield23 jackschofield23 jackschofield23 approved these changes

Assignees

@mocsharp mocsharp

Labels

enhancement Enhancement to existing feature

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

HL7v2 MLLP Server

3 participants

@mocsharp @jackschofield23