Skip to content

Conversation

lillie-dae
Copy link
Contributor

Description

Issues with connection being refreshed too much...
too resolve this I have put a check in on shutdown/exception events to check if the connection is still open.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #102 (244fffa) into develop (d69f0c5) will decrease coverage by 3.43101%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #102         +/-   ##
===================================================
- Coverage   81.96982%   78.53881%   -3.43102%     
===================================================
  Files             42          42                 
  Lines           1259        1314         +55     
  Branches          75          83          +8     
===================================================
  Hits            1032        1032                 
- Misses           201         256         +55     
  Partials          26          26                 
Flag Coverage Δ
unittests 78.53881% <0.00000%> (-3.43102%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/RabbitMQ/Factory/RabbitMqConnectionFactory.cs 0.00000% <0.00000%> (ø)
src/Plugins/RabbitMQ/Logger.cs 0.00000% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69f0c5...244fffa. Read the comment docs.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae lillie-dae merged commit 7efbebf into develop Nov 9, 2022
mocsharp added a commit that referenced this pull request Nov 9, 2022
@mocsharp mocsharp deleted the connection-resiliency-take2 branch September 12, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants