Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 10, 2022

Description

Removes RMQ dependency from the base API library

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Nov 10, 2022
@mocsharp mocsharp added this to the 0.1.12 milestone Nov 10, 2022
@mocsharp mocsharp self-assigned this Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #106 (a748244) into develop (cc13a7d) will increase coverage by 0.06462%.
The diff coverage is 87.50000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #106         +/-   ##
===================================================
+ Coverage   82.26060%   82.32522%   +0.06462%     
===================================================
  Files             42          41          -1     
  Lines           1274        1273          -1     
  Branches          81          80          -1     
===================================================
  Hits            1048        1048                 
+ Misses           197         196          -1     
  Partials          29          29                 
Flag Coverage Δ
unittests 82.32522% <87.50000%> (+0.06462%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tMQ/Subscriber/RabbitMqMessageSubscriberService.cs 79.68127% <0.00000%> (ø)
src/Messaging/Events/ExportCompleteEvent.cs 100.00000% <100.00000%> (ø)
...bitMQ/Publisher/RabbitMqMessagePublisherService.cs 75.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc13a7d...a748244. Read the comment docs.

@mocsharp mocsharp merged commit a5c5823 into develop Nov 10, 2022
@mocsharp mocsharp deleted the vchang/connection-resiliency branch November 10, 2022 16:27
@mocsharp mocsharp restored the vchang/connection-resiliency branch November 10, 2022 16:27
@mocsharp mocsharp deleted the vchang/connection-resiliency branch November 10, 2022 16:27
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.14 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants