Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 14, 2022

Description

After running for a while, the health check API may exhaust all available channels in a RabbitMQ connection.
Fix to close the channel at the end of the check.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp added the bug Something isn't working label Sep 14, 2022
@mocsharp mocsharp added this to the 0.1.5 milestone Sep 14, 2022
mocsharp and others added 2 commits September 14, 2022 16:37
Remove length limit for Identity
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/close-channel-for-healthcheck branch from 0fc1e5f to e0d5559 Compare September 14, 2022 23:38
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #71 (7a9c59f) into release/0.1.5 (a9ec685) will increase coverage by 0.04090%.
The diff coverage is 85.71429%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/0.1.5         #71         +/-   ##
=======================================================
+ Coverage       83.92857%   83.96947%   +0.04090%     
=======================================================
  Files                 41          41                 
  Lines               1176        1179          +3     
  Branches              68          68                 
=======================================================
+ Hits                 987         990          +3     
  Misses               165         165                 
  Partials              24          24                 
Flag Coverage Δ
unittests 83.96947% <85.71429%> (+0.04090%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Messaging/Events/TaskCallbackEvent.cs 100.00000% <ø> (ø)
src/Messaging/Tests/TaskCallbackEventTest.cs 100.00000% <ø> (ø)
src/Plugins/RabbitMQ/RabbitMQHealthCheck.cs 76.47059% <50.00000%> (+1.47059%) ⬆️
.../Plugins/RabbitMQ/Tests/RabbitMQHealthCheckTest.cs 100.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ec685...7a9c59f. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit b7229a8 into release/0.1.5 Sep 20, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.5 🎉

The release is available on:

@mocsharp mocsharp deleted the vchang/close-channel-for-healthcheck branch September 12, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants