Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 6, 2022

Description

Update the ExportCompleteEvent to include a FileExportStatus for each file.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the enhancement New feature or request label Oct 6, 2022
@mocsharp mocsharp added this to the 0.1.7 milestone Oct 6, 2022
@mocsharp mocsharp self-assigned this Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #83 (6812f54) into develop (8a2355c) will increase coverage by 0.01373%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #83         +/-   ##
===================================================
+ Coverage   83.75635%   83.77008%   +0.01372%     
===================================================
  Files             41          41                 
  Lines           1182        1183          +1     
  Branches          68          68                 
===================================================
+ Hits             990         991          +1     
  Misses           168         168                 
  Partials          24          24                 
Flag Coverage Δ
unittests 83.77008% <100.00000%> (+0.01372%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Messaging/Events/ExportCompleteEvent.cs 100.00000% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2355c...6812f54. Read the comment docs.

Copy link
Collaborator

@neildsouth neildsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used ? I cant see anything setting these ?

@mocsharp mocsharp merged commit 5836939 into develop Oct 6, 2022
@mocsharp
Copy link
Collaborator Author

mocsharp commented Oct 6, 2022

is this used ? I cant see anything setting these ?

These changes will be used by MIG when it publishes the export complete events.

@mocsharp mocsharp deleted the vchang/export-event branch October 6, 2022 16:33
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.7 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants