Skip to content

Conversation

lillie-dae
Copy link
Contributor

Description

Fixes # .

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae lillie-dae self-assigned this Nov 4, 2022
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #98 (a6cf637) into develop (f3cd5eb) will decrease coverage by 1.98363%.
The diff coverage is 33.33333%.

❗ Current head a6cf637 differs from pull request most recent head c29f4c6. Consider uploading reports for the commit c29f4c6 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #98         +/-   ##
===================================================
- Coverage   83.97071%   81.98708%   -1.98363%     
===================================================
  Files             41          42          +1     
  Lines           1229        1238          +9     
  Branches          71          72          +1     
===================================================
- Hits            1032        1015         -17     
- Misses           171         199         +28     
+ Partials          26          24          -2     
Flag Coverage Δ
unittests 81.98708% <33.33333%> (-1.98363%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Plugins/RabbitMQ/Factory/CreateChannelArguments.cs 0.00000% <0.00000%> (ø)
...gins/RabbitMQ/Factory/RabbitMqConnectionFactory.cs 0.00000% <0.00000%> (ø)
...tMQ/Publisher/PublisherServicHealthCheckBuilder.cs 69.23077% <ø> (ø)
...RabbitMQ/Publisher/PublisherServiceRegistration.cs 100.00000% <ø> (ø)
...bitMQ/Publisher/RabbitMqMessagePublisherService.cs 75.00000% <ø> (ø)
...Q/Subscriber/SubscriberServicHealthCheckBuilder.cs 69.23077% <ø> (ø)
...bbitMQ/Subscriber/SubscriberServiceRegistration.cs 100.00000% <ø> (ø)
...tMQ/Subscriber/RabbitMqMessageSubscriberService.cs 84.34343% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053c387...c29f4c6. Read the comment docs.

@lillie-dae lillie-dae marked this pull request as ready for review November 4, 2022 14:41
@mocsharp mocsharp added the bug Something isn't working label Nov 4, 2022
@mocsharp mocsharp added this to the 0.1.10 milestone Nov 4, 2022
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
…oy-messaging into AC-824-task-manager-rabbit-connection-resiliency-issues
@lillie-dae lillie-dae merged commit d69f0c5 into develop Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This issue has been resolved in version 0.1.10 🎉

The release is available on:

@mocsharp mocsharp deleted the AC-824-task-manager-rabbit-connection-resiliency-issues branch September 12, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants