Skip to content

When license header scan fails the message that explains the next steps is confusing #311

@RemakingEden

Description

@RemakingEden

Description

In the license scanning workflow we have a check for licenses for the packages and a check for the license header. There is a step that explains what a user should do if this fails and currently the info is only related to the license check not the license header check.

Steps to reproduce

Please share a clear and concise description of the problem.

  1. Create a PR where a license header is missing
  2. Wait for license scanning test to fail
  3. Read the "check this step to see how to resolve failure" step output
    ...

Expected behavior

This would include info on how to resolve license check and licence header check

Actual behavior

The information only helps for license check and is confusing for the license header check failure

image
https://github.com/Project-MONAI/monai-deploy-workflow-manager/runs/7746505013?check_suite_focus=true

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions