Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jul 20, 2022

Description

Fixes #196 & #252

  • Stores incoming task dispatch events after calling the plug-in
  • Upon receiving a task callback event, TM queries the database to look up the stored task dispatch event and constructs a new instance of the specified plug-in.
  • Deletes the task dispatch event from the database upon completion of the callback event.
  • Deletes any user accounts created by ExecuteTask upon completion of the callback event.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added this to the 0.2 milestone Jul 20, 2022
@mocsharp mocsharp self-assigned this Jul 20, 2022
@mocsharp mocsharp modified the milestones: 0.2, 0.1 - MVP Jul 20, 2022
@mocsharp mocsharp force-pushed the vchang/gh-196 branch 6 times, most recently from 3134564 to f4d93a2 Compare July 22, 2022 16:29
@mocsharp mocsharp force-pushed the vchang/gh-196 branch 2 times, most recently from 9daca79 to 49cb100 Compare July 25, 2022 16:25
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5126 files.

Valid Invalid Ignored Fixed
291 9 4826 0
Click to see the invalid file list
  • src/TaskManager/API/ITaskDispatchEventService.cs
  • src/TaskManager/Database/ITaskDispatchEventRepository.cs
  • src/TaskManager/Database/Logging/Log.1000.Database.cs
  • src/TaskManager/Database/Monai.Deploy.WorkflowManager.TaskManager.Database.csproj
  • src/TaskManager/Database/Options/TaskManagerDatabaseSettings.cs
  • src/TaskManager/Database/TaskDispatchEventRepository.cs
  • src/TaskManager/Services/TaskDispatchEventService.cs
  • src/TaskManager/TaskManagerException.cs
  • tests/IntegrationTests/TaskManager.IntegrationTests/Support/MongoClientUtil.cs

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5126 files.

Valid Invalid Ignored Fixed
291 9 4826 0
Click to see the invalid file list
  • src/TaskManager/API/ITaskDispatchEventService.cs
  • src/TaskManager/Database/ITaskDispatchEventRepository.cs
  • src/TaskManager/Database/Logging/Log.1000.Database.cs
  • src/TaskManager/Database/Monai.Deploy.WorkflowManager.TaskManager.Database.csproj
  • src/TaskManager/Database/Options/TaskManagerDatabaseSettings.cs
  • src/TaskManager/Database/TaskDispatchEventRepository.cs
  • src/TaskManager/Services/TaskDispatchEventService.cs
  • src/TaskManager/TaskManagerException.cs
  • tests/IntegrationTests/TaskManager.IntegrationTests/Support/MongoClientUtil.cs

@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
@Project-MONAI Project-MONAI deleted a comment from github-actions bot Jul 25, 2022
mocsharp added 2 commits July 28, 2022 09:19
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 53 Code Smells

30.8% 30.8% Coverage
0.0% 0.0% Duplication

@mocsharp mocsharp merged commit 6f15f12 into develop Jul 28, 2022
@mocsharp mocsharp deleted the vchang/gh-196 branch July 28, 2022 16:40
@mocsharp
Copy link
Collaborator Author

mocsharp commented Jul 28, 2022

Closing #196

@mocsharp
Copy link
Collaborator Author

Closing #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

Task manager persistence

2 participants