Skip to content

254 clinical review reviewed task #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 29, 2022
Merged

254 clinical review reviewed task #259

merged 10 commits into from
Jul 29, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Jul 25, 2022 •
edited
Loading

Implements #254

Description

Basic workflow validation on workflow API.

  • fixes the aide clinical review plugin
  • fixes conditional resolver to be to the workflow spec

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
  • Any new files have copyright headers
  • Code coverage above 70%
  • TODO items resolved

@jackschofield23 jackschofield23 changed the title Jschofield/254 clinical review reviewed task 254 clinical review reviewed task Jul 25, 2022
@jackschofield23 jackschofield23 marked this pull request as ready for review July 26, 2022 08:37
@jackschofield23 jackschofield23 force-pushed the jschofield/254-clinical-review-reviewed-task-id branch from 7bfbc24 to 7cf8959 Compare July 26, 2022 08:50
lillie-dae
lillie-dae reviewed Jul 26, 2022
View reviewed changes
lillie-dae
lillie-dae reviewed Jul 26, 2022
View reviewed changes
@jackschofield23 jackschofield23 force-pushed the jschofield/254-clinical-review-reviewed-task-id branch from bfcecab to ec3ee66 Compare July 28, 2022 09:56
@jackschofield23
update clinical review plugin
491a21f 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix tests and update parser
03a7b8b 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add tests
21cce4e 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
make static
b26640e 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
change workflow spec
c2eb146 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix magic strings
7cd0976 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add license header
f66f08d 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix test data
0e29064 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
remove culture
caf03c3 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add culture
5232174 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/254-clinical-review-reviewed-task-id branch from 8c854a8 to 5232174 Compare July 29, 2022 08:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

79.3% 79.3% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit da745c1 into develop Jul 29, 2022
@mocsharp mocsharp deleted the jschofield/254-clinical-review-reviewed-task-id branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lillie-dae lillie-dae lillie-dae approved these changes

@neildsouth neildsouth Awaiting requested review from neildsouth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackschofield23 @lillie-dae