end to end fixs #260
Merged
end to end fixs #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil South <neil.south@answerdigital.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 5088 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 290 | 3 | 4795 | 0 |
Click to see the invalid file list
- guidelines/mwm-developer-setup.md
- guidelines/mwm-workflow-spec.md
- src/PayloadListener/Extensions/CollectionExtensions.cs
Signed-off-by: Neil South <neil.south@answerdigital.com>
mocsharp
reviewed
Jul 25, 2022
mocsharp
reviewed
Jul 25, 2022
Signed-off-by: Neil South <neil.south@answerdigital.com>
jackschofield23
approved these changes
Jul 26, 2022
Signed-off-by: Neil South <neil.south@answerdigital.com>
|
SonarCloud Quality Gate failed. |
lillie-dae
reviewed
Jul 26, 2022
| await Task.WhenAll(tasks); | ||
| workflowInstances.AddRange(tasks.Select(t => t.Result)); | ||
|
|
||
| Debug.Assert(workflowInstances.Count > 0); |
There was a problem hiding this comment.
is this debugging code left in?
lillie-dae
reviewed
Jul 26, 2022
| var workflowInstance = await CreateWorkflowInstanceAsync(message, workflow); | ||
| workflowInstances.Add(workflowInstance); | ||
| } | ||
| var tasks = workflows.Select(workflow => CreateWorkflowInstanceAsync(message, workflow)); |
There was a problem hiding this comment.
would this be simpler as
var workflowInstances = await workflows.Select(async workflow => await CreateWorkflowInstanceAsync(message, workflow));
I think is the syntax?
lillie-dae
reviewed
Jul 26, 2022
| "storage": { | ||
| "serviceAssemblyName": "Monai.Deploy.Storage.MinIO.MinIoStorageService, Monai.Deploy.Storage.MinIO", | ||
| "settings": { | ||
| "endpoint": "minio:30090", // note edit C:\Windows\System32\drivers\etc\Hosts fand add `127.0.0.1 minio` |
There was a problem hiding this comment.
I dont think putting comments like this in json like this is valid.
There was a problem hiding this comment.
lillie-dae
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neil South neil.south@answerdigital.com
Description
Fixes # .
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes