Skip to content

fix warnings #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 3, 2022
Merged

fix warnings #271

merged 9 commits into from
Aug 3, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Aug 1, 2022 •
edited
Loading

Description

Fixes # .

Fixes a lot of the warnings currently in the projct

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 force-pushed the jschofield/fix-warnings branch 2 times, most recently from 317b67c to 5044e12 Compare August 1, 2022 13:22
@jackschofield23 jackschofield23 marked this pull request as ready for review August 1, 2022 14:04
lillie-dae
lillie-dae reviewed Aug 2, 2022
View reviewed changes
lillie-dae
lillie-dae reviewed Aug 2, 2022
View reviewed changes
@jackschofield23
fix warnings
487e68f 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix headers
52d898d 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix rest of headers
8026ddc 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
modify license
7d54ec3 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
revert headers
1474ab5 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix code smells
818806c 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add stylecop
5f6cb7d 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/fix-warnings branch from 819cc51 to 5f6cb7d Compare August 2, 2022 15:21
@jackschofield23
fix rebase
8996490 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix more warnings
c6bb1e3 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 74 Code Smells

18.4% 18.4% Coverage
1.4% 1.4% Duplication

@jackschofield23 jackschofield23 merged commit 0ebd0d6 into develop Aug 3, 2022
@jackschofield23 jackschofield23 deleted the jschofield/fix-warnings branch August 3, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lillie-dae lillie-dae lillie-dae approved these changes

@neildsouth neildsouth neildsouth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackschofield23 @lillie-dae @neildsouth