Skip to content

use task level export destinations #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 2, 2022
Merged

use task level export destinations #278

merged 6 commits into from
Aug 2, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Aug 2, 2022 •
edited
Loading

Description

changes export destinations to use the task level export, and validates against the
Fixes # .

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 marked this pull request as ready for review August 2, 2022 11:12
lillie-dae
lillie-dae reviewed Aug 2, 2022
View reviewed changes
lillie-dae
lillie-dae reviewed Aug 2, 2022
View reviewed changes
lillie-dae
lillie-dae reviewed Aug 2, 2022
View reviewed changes
@jackschofield23 jackschofield23 force-pushed the jschofield/274-task-level-export-destinations branch from 4a9f7e8 to f6339c0 Compare August 2, 2022 13:39
@jackschofield23
use task level export destinations
7e20e91 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix
a7a26d4 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
update docs
398ca48 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
address comments
9f84cc0 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/274-task-level-export-destinations branch from f6339c0 to 9f84cc0 Compare August 2, 2022 13:52
@jackschofield23
fix system
4a6033e 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
license
da51eba 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

76.6% 76.6% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit 1f530b7 into develop Aug 2, 2022
@jackschofield23 jackschofield23 deleted the jschofield/274-task-level-export-destinations branch August 2, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lillie-dae lillie-dae lillie-dae approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackschofield23 @lillie-dae