remove parameter parser #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jackschofield23 merged 2 commits into develop from jschofield/272-remove-parameter-parser

Aug 3, 2022

Contributor

jackschofield23 commented Aug 3, 2022 •

edited

Loading

Description

Removes the parameter parser from the argo plugin

Status

Work in progress

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
All tests passed locally.
Documentation comments included/updated.


          remove parameter parser

a6d39d9

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>

jackschofield23 requested a review from lillie-dae

August 3, 2022 10:00

jackschofield23 marked this pull request as ready for review

August 3, 2022 10:01


          fix code smell

c03c613

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>

sonarqubecloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

lillie-dae approved these changes

View reviewed changes

jackschofield23 merged commit 097e554 into develop

jackschofield23 deleted the jschofield/272-remove-parameter-parser branch

August 3, 2022 12:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet