seperate task manager + workflow manager #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jackschofield23
force-pushed
the
jschofield/seperate-task-manager
branch
2 times, most recently
from
f6516a3 to
da08f88
Compare
jackschofield23
force-pushed
the
jschofield/seperate-task-manager
branch
from
4e31edc to
1d9c3f5
Compare
mocsharp
approved these changes
Aug 8, 2022
|
@mocsharp I think that may be best for a refactor, as on the workflow side, we have workflowManager as the top level project, and a separate project called workflow executer with the workflow specific logic, we could copy this in the task manager. |
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
jackschofield23
force-pushed
the
jschofield/seperate-task-manager
branch
from
1d9c3f5 to
147d711
Compare
|
SonarCloud Quality Gate failed. |
|
Is this separation meaning that they will end up being potentially 2 different containers or services (Helm charts)? @nakfour ^^ |
Correct, 2 container images/services/helm charts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seperates workflow manager and task manager
Status
Work in progress
Types of changes