Skip to content

Update License header feedback when fails #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Update License header feedback when fails #313

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee1a4d8
Added a condition to the next steps in license scanning
RemakingEden Aug 9, 2022
3f3bdbd
Merge branch 'develop' into jsparkes/311-update-license-scanning-fail…
RemakingEden Aug 9, 2022
284d2d4
Removed header for test of new conditions
RemakingEden Aug 9, 2022
7581f3a
Test
RemakingEden Aug 9, 2022
466a318
xSpelling mistake, another test
RemakingEden Aug 9, 2022
87aff1d
Added back license allowlist
RemakingEden Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/license-scanning.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ jobs:
working-directory: ./src

- name: Perform License Scanning
id: license_scanning
run: license_finder -r

- name: Check License Header
uses: apache/skywalking-eyes@main

- name: Check this step to see how to resolve failure
if: ${{ failure() }}
- name: Check this step to see how to resolve failure with license scanning
if: ${{ failure() && steps.license_scanning.conclusion == 'failure' }}
run: echo "You have added a new package that needs to be manually checked to ensure it fits our license allowances. Please read the 'License Scanning' section of the 'CONTRIBUTING.MD' file to see what the next steps are."