Skip to content

fix running tasks #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 15, 2022
Merged

fix running tasks #315

merged 5 commits into from
Aug 15, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Aug 10, 2022 •
edited
Loading

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes # .

Fixes the running tasks to return currently running tasks.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 force-pushed the jschofield/308-running-tasks-not-correct branch from 4edd316 to efed9d5 Compare August 11, 2022 09:56
@jackschofield23 jackschofield23 marked this pull request as ready for review August 11, 2022 09:57
@RemakingEden
Copy link
Member

Closes #312

@jackschofield23 jackschofield23 force-pushed the jschofield/308-running-tasks-not-correct branch 2 times, most recently from ed09e58 to 83bae78 Compare August 12, 2022 14:45
@jackschofield23
fix running tasks
51e6346 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add no task test
a71dc76 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix test
5ea4df5 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
remove unused file
689969c 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix rebase issues
bfd1658 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/308-running-tasks-not-correct branch from 83bae78 to bfd1658 Compare August 15, 2022 07:48
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 151 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit bd8ffe2 into develop Aug 15, 2022
@mocsharp mocsharp deleted the jschofield/308-running-tasks-not-correct branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemakingEden RemakingEden RemakingEden approved these changes

@lillie-dae lillie-dae lillie-dae approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackschofield23 @RemakingEden @lillie-dae