Skip to content

add controller logging #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 18, 2022
Merged

add controller logging #322

merged 9 commits into from
Aug 18, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Aug 16, 2022 •
edited
Loading

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes # .

Adds logging for each endpoint.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 marked this pull request as ready for review August 16, 2022 12:52
@jackschofield23 jackschofield23 force-pushed the jschofield/add-controller-logging branch from faeebb4 to 4c07bd1 Compare August 16, 2022 13:26
lillie-dae
lillie-dae reviewed Aug 18, 2022
View reviewed changes
@jackschofield23 jackschofield23 force-pushed the jschofield/add-controller-logging branch 2 times, most recently from c07d074 to 81fd77f Compare August 18, 2022 12:29
@jackschofield23
add controller logging
e5bc477 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix build
2157ae3 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix license
13ef0d0 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add result
29269e9 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add licenses
19e501e 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add more licenses
a6a24dc 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
fix stash msg
c17d427 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
add more licenses
373f706 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
final license
6924d69 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/add-controller-logging branch from 81fd77f to 6924d69 Compare August 18, 2022 12:39
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 8 Code Smells

4.1% 4.1% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit 4812d7d into develop Aug 18, 2022
@mocsharp mocsharp deleted the jschofield/add-controller-logging branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lillie-dae lillie-dae lillie-dae approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackschofield23 @lillie-dae