Skip to content

Removed task missing status test #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Removed task missing status test #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Features/TaskStatusUpdate.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ Scenario Outline: Publish an invalid Task Update event which does not update the
| Task_Status_Update_Missing_TaskId |
| Task_Status_Update_Missing_ExecutionId |
| Task_Status_Update_Missing_CorrelationId |
| Task_Status_Update_Missing_Status |

@TaskUpdate
Scenario Outline: Publish an valid Task Update event with a status that is invalid for current status
Expand Down
19 changes: 8 additions & 11 deletions tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Support/DataHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,17 +237,14 @@ public TaskUpdateEvent GetTaskUpdateTestData(string name, string updateStatus)

if (taskUpdateTestData != null && taskUpdateTestData.TaskUpdateEvent != null)
{
if (!taskUpdateTestData.Name.Contains("Missing_Status"))
{
taskUpdateTestData.TaskUpdateEvent.Status = updateStatus.ToLower() switch
{
"accepted" => TaskExecutionStatus.Accepted,
"succeeded" => TaskExecutionStatus.Succeeded,
"failed" => TaskExecutionStatus.Failed,
"canceled" => TaskExecutionStatus.Canceled,
_ => throw new Exception($"updateStatus {updateStatus} is not recognised. Please check and try again."),
};
}
taskUpdateTestData.TaskUpdateEvent.Status = updateStatus.ToLower() switch
{
"accepted" => TaskExecutionStatus.Accepted,
"succeeded" => TaskExecutionStatus.Succeeded,
"failed" => TaskExecutionStatus.Failed,
"canceled" => TaskExecutionStatus.Canceled,
_ => throw new Exception($"updateStatus {updateStatus} is not recognised. Please check and try again."),
};

TaskUpdateEvent = taskUpdateTestData.TaskUpdateEvent;

Expand Down
16 changes: 0 additions & 16 deletions tests/IntegrationTests/WorkflowExecutor.IntegrationTests/TestData/TaskUpdateTestData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,22 +228,6 @@ public static TaskUpdateEvent CreateTaskUpdateEvent(string workflowInstanceName)
}
},
new TaskUpdateTestData()
{
Name = "Task_Status_Update_Missing_Status",
TaskUpdateEvent = new TaskUpdateEvent()
{
WorkflowInstanceId = Helper.GetWorkflowInstanceByName("WFI_Task_Status_Update").WorkflowInstance.Id,
ExecutionId = Helper.GetWorkflowInstanceByName("WFI_Task_Status_Update").WorkflowInstance.Tasks[0].ExecutionId,
CorrelationId = Guid.NewGuid().ToString(),
Reason = FailureReason.None,
Message = "Task Message",
TaskId = Helper.GetWorkflowInstanceByName("WFI_Task_Status_Update").WorkflowInstance.Tasks[0].TaskId,
Metadata = new Dictionary<string, object>()
{
}
}
},
new TaskUpdateTestData()
{
Name = "Task_Status_Update_Status_Invalid_When_Succeeded",
TaskUpdateEvent = new TaskUpdateEvent()
Expand Down