Skip to content

fix task dispatch persistence #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2022
Merged

fix task dispatch persistence #341

merged 5 commits into from
Aug 23, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Aug 18, 2022 •
edited
Loading

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes # .

Moves the task dispatch storage to the start of the request and uncomments the tests

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 changed the title fix task storage fix task dispatch persistence Aug 18, 2022
@jackschofield23 jackschofield23 marked this pull request as ready for review August 19, 2022 08:46
@jackschofield23
fix task storage
fdc63b8 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
uncomment tests
1a8be88 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
Add polly
98c292d 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
RemakingEden
RemakingEden approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test section LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 merged commit cbb183e into develop Aug 23, 2022
@jackschofield23 jackschofield23 deleted the fix-task-persistance branch August 23, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemakingEden RemakingEden RemakingEden approved these changes

@mocsharp mocsharp Awaiting requested review from mocsharp

@lillie-dae lillie-dae Awaiting requested review from lillie-dae

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackschofield23 @RemakingEden