Skip to content

Conversation

lillie-dae
Copy link
Collaborator

Description

minor fix for argo task parameters.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #388 (77a35ae) into develop (b6e1744) will decrease coverage by 0.03004%.
The diff coverage is 0.00000%.

❗ Current head 77a35ae differs from pull request most recent head 4bc9b92. Consider uploading reports for the commit 4bc9b92 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #388         +/-   ##
===================================================
- Coverage   58.93604%   58.90600%   -0.03004%     
===================================================
  Files            135         135                 
  Lines          16730       16691         -39     
  Branches        1736        1732          -4     
===================================================
- Hits            9860        9832         -28     
+ Misses          6558        6552          -6     
+ Partials         312         307          -5     
Flag Coverage Δ
unittests 58.90600% <0.00000%> (-0.03004%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs 87.00855% <0.00000%> (-1.20636%) ⬇️
...c/WorkflowManager/Storage/Services/DicomService.cs 33.07087% <0.00000%> (-11.68438%) ⬇️
...rkflowExecuter/Services/WorkflowExecuterService.cs 69.39252% <0.00000%> (-0.63036%) ⬇️
...Manager/Common/Services/WorkflowInstanceService.cs 0.00000% <0.00000%> (ø)
...anager/Database/Repositories/WorkflowRepository.cs 0.00000% <0.00000%> (ø)
...atabase/Repositories/WorkflowInstanceRepository.cs 0.00000% <0.00000%> (ø)
...wManager/Controllers/WorkflowInstanceController.cs 80.43478% <0.00000%> (ø)
...r/PayloadListener/Extensions/WorkflowExtensions.cs 80.59701% <0.00000%> (+3.32428%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6aaeb9...4bc9b92. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lillie-dae lillie-dae merged commit e487a9c into develop Sep 29, 2022
@mocsharp mocsharp deleted the argo-plugin-parameters-fix branch June 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants