Skip to content

Conversation

lillie-dae
Copy link
Collaborator

@lillie-dae lillie-dae commented Sep 2, 2022

Signed-off-by: Lillie Dae lillie.dae@answerdigital.com

Description

Fixes #387.

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae lillie-dae self-assigned this Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #394 (590bf28) into develop (e61ac4e) will increase coverage by 0.15832%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #394         +/-   ##
===================================================
+ Coverage   56.57895%   56.73727%   +0.15832%     
===================================================
  Files            125         125                 
  Lines          15504       15533         +29     
  Branches        1653        1656          +3     
===================================================
+ Hits            8772        8813         +41     
+ Misses          6464        6450         -14     
- Partials         268         270          +2     
Flag Coverage Δ
unittests 56.73727% <100.00000%> (+0.15832%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rkflowExecuter/Services/WorkflowExecuterService.cs 70.55961% <100.00000%> (+1.34841%) ⬆️
...ter.Tests/Services/WorkflowExecuterServiceTests.cs 100.00000% <100.00000%> (ø)
...vices/DataRetentionService/DataRetentionService.cs 94.11765% <0.00000%> (+2.94118%) ⬆️
...ug-ins/Argo/Repositories/ArgoMetadataRepository.cs 79.06977% <0.00000%> (+9.30233%) ⬆️
src/TaskManager/API/MetadataRepositoryBase.cs 50.00000% <0.00000%> (+38.88889%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61ac4e...590bf28. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lillie-dae lillie-dae merged commit 3894d8d into develop Sep 5, 2022
@mocsharp mocsharp deleted the AC-506-export-task-does-not-support-folders-387 branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export task does not support folders

3 participants