fix misc issues

[jackschofield23]

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes # .

Fixes a few problems spotted when trying to run the argo task via the workflow manager

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• All tests passed locally.
• Documentation comments included/updated.

[codecov]

Codecov Report

Merging #395 (8379d69) into develop (3894d8d) will increase coverage by 0.22476%.
The diff coverage is 91.42857%.

@@                 Coverage Diff                 @@
##             develop        #395         +/-   ##
===================================================
+ Coverage   56.73727%   56.96203%   +0.22475%     
===================================================
  Files            125         125                 
  Lines          15533       15642        +109     
  Branches        1656        1662          +6     
===================================================
+ Hits            8813        8910         +97     
- Misses          6450        6457          +7     
- Partials         270         275          +5     

Flag	Coverage Δ
unittests	56.96203% <91.42857%> (+0.22475%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...r/TaskManager/Services/TaskDispatchEventService.cs	0.00000% <0.00000%> (ø)
...rkflowExecuter/Services/WorkflowExecuterService.cs	69.64706% <46.66667%> (-0.91256%)	⬇️
...wManager/WorkflowExecuter/Common/ArtifactMapper.cs	78.57143% <72.72727%> (-1.69173%)	⬇️
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs	88.01431% <100.00000%> (ø)
src/TaskManager/TaskManager/TaskManager.cs	68.99225% <100.00000%> (ø)
...UnitTests/TaskManager.Argo.Tests/ArgoPluginTest.cs	98.39884% <100.00000%> (ø)
...rkflowExecuter.Tests/Common/ArtifactMapperTests.cs	100.00000% <100.00000%> (ø)
...ter.Tests/Services/WorkflowExecuterServiceTests.cs	100.00000% <100.00000%> (ø)
...Tests/WorkflowManager.Tests/DummyStorageService.cs	13.04348% <100.00000%> (-3.62319%)	⬇️
...vices/DataRetentionService/DataRetentionService.cs	91.17647% <0.00000%> (-2.94119%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3894d8d...8379d69. Read the comment docs.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

70.0% Coverage
0.0% Duplication

[neildsouth]

is it possible to leave this file as is ? or go through and update the developer-setup accordingly :)

[lillie-dae]

I'm trying to think is it possible to have multiple variables in this field?
might be worth doing variableStrings.Last() I think thats linq way of getting last element.