Skip to content

Conversation

neildsouth
Copy link
Collaborator

@neildsouth neildsouth commented Sep 2, 2022

Description

addresses #391

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #397 (d078a1b) into develop (b6e1744) will increase coverage by 0.08593%.
The diff coverage is 53.33333%.

❗ Current head d078a1b differs from pull request most recent head 7a4556c. Consider uploading reports for the commit 7a4556c to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #397         +/-   ##
===================================================
+ Coverage   58.93604%   59.02197%   +0.08593%     
===================================================
  Files            135         134          -1     
  Lines          16730       16748         +18     
  Branches        1736        1735          -1     
===================================================
+ Hits            9860        9885         +25     
+ Misses          6558        6553          -5     
+ Partials         312         310          -2     
Flag Coverage Δ
unittests 59.02197% <53.33333%> (+0.08593%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/TaskManager/TaskManager/Program.cs 0.00000% <0.00000%> (ø)
...rkflowManager/Logging/Attributes/AuditAttribute.cs 0.00000% <0.00000%> (ø)
...c/WorkflowManager/MonaiBackgroundService/Worker.cs 68.25397% <0.00000%> (ø)
...owManager/WorkflowManager/Services/Http/Startup.cs 47.91667% <ø> (ø)
src/WorkflowManager/Logging/Logging/Log.cs 16.66667% <20.00000%> (-8.33334%) ⬇️
...rkflowExecuter/Services/WorkflowExecuterService.cs 69.60557% <60.00000%> (-0.41732%) ⬇️
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs 88.33619% <100.00000%> (+0.12129%) ⬆️
src/TaskManager/TaskManager/TaskManager.cs 70.29703% <100.00000%> (+1.30478%) ⬆️
...adListener/Services/EventPayloadRecieverService.cs 82.79570% <100.00000%> (+2.54878%) ⬆️
src/WorkflowManager/WorkflowManager/Program.cs 83.50515% <100.00000%> (+2.78225%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf77759...7a4556c. Read the comment docs.

Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

52.7% 52.7% Coverage
1.5% 1.5% Duplication

@neildsouth neildsouth merged commit 2037e0b into develop Sep 26, 2022
@neildsouth neildsouth deleted the #391_nds_addlogging branch September 26, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants