Skip to content

Conversation

neildsouth
Copy link
Collaborator

Description

Fixes # .

An issue where imagePullSecrets in Argo templates weren't copied across to the triggered Argo workflow

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #404 (01176ac) into develop (6e4a1e9) will increase coverage by 0.01957%.
The diff coverage is 97.61905%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #404         +/-   ##
===================================================
+ Coverage   56.98120%   57.00077%   +0.01957%     
===================================================
  Files            125         125                 
  Lines          15642       15684         +42     
  Branches        1662        1665          +3     
===================================================
+ Hits            8913        8940         +27     
- Misses          6454        6470         +16     
+ Partials         275         274          -1     
Flag Coverage Δ
unittests 57.00077% <97.61905%> (+0.01957%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...UnitTests/TaskManager.Argo.Tests/ArgoPluginTest.cs 98.32869% <96.77419%> (-0.07016%) ⬇️
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs 88.24561% <100.00000%> (+0.05240%) ⬆️
src/TaskManager/API/MetadataRepositoryBase.cs 11.11111% <0.00000%> (-38.88890%) ⬇️
...ug-ins/Argo/Repositories/ArgoMetadataRepository.cs 69.76744% <0.00000%> (-9.30234%) ⬇️
src/TaskManager/API/TaskPluginBase.cs 88.23529% <0.00000%> (-5.88236%) ⬇️
...vices/DataRetentionService/DataRetentionService.cs 91.17647% <0.00000%> (-2.94119%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4a1e9...01176ac. Read the comment docs.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@neildsouth neildsouth merged commit bb565e1 into develop Sep 6, 2022
@neildsouth neildsouth deleted the nds-fix-for-imagepullsecrets branch September 6, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants