Skip to content

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 7, 2022

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes #381

Updates the workflow validation to allow empty objects

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #408 (b7f465a) into develop (6f93c24) will decrease coverage by 0.00917%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #408         +/-   ##
===================================================
- Coverage   57.08365%   57.07448%   -0.00917%     
===================================================
  Files            125         125                 
  Lines          15684       15669         -15     
  Branches        1665        1661          -4     
===================================================
- Hits            8953        8943         -10     
+ Misses          6455        6450          -5     
  Partials         276         276                 
Flag Coverage Δ
unittests 57.07448% <100.00000%> (-0.00917%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/PayloadListener/Extensions/WorkflowExtensions.cs 80.59701% <ø> (-2.32982%) ⬇️
...ager.Tests/Controllers/WorkflowsControllerTests.cs 100.00000% <100.00000%> (ø)
...ins/AideClinicalReview/AideClinicalReviewPlugin.cs 80.00000% <0.00000%> (+3.47826%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f93c24...b7f465a. Read the comment docs.

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the update-workflow-validation branch from e9864fd to b7f465a Compare September 8, 2022 08:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackschofield23 jackschofield23 merged commit f1e2abd into develop Sep 8, 2022
@jackschofield23 jackschofield23 deleted the update-workflow-validation branch September 8, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/workflow endpoint requires all objects even if they are null

2 participants