Skip to content

Conversation

RemakingEden
Copy link
Member

@RemakingEden RemakingEden commented Sep 8, 2022

Signed-off-by: RemakingEden joss.sparkes@gmail.com

Description

A task manager test is currently being flaky and takes a few runs to work. @jackschofield23 and I have looked and it seems the test is invalid as without mc.exe an argo task cannot be run and is retried. This was why the test was being flaky.

Status

Ready

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #412 (ba15afa) into develop (f1e2abd) will increase coverage by 0.08296%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #412         +/-   ##
===================================================
+ Coverage   56.97237%   57.05533%   +0.08295%     
===================================================
  Files            125         125                 
  Lines          15669       15669                 
  Branches        1661        1661                 
===================================================
+ Hits            8927        8940         +13     
+ Misses          6469        6454         -15     
- Partials         273         275          +2     
Flag Coverage Δ
unittests 57.05533% <ø> (+0.08295%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs 88.42105% <0.00000%> (+0.17543%) ⬆️
src/TaskManager/API/TaskPluginBase.cs 94.11765% <0.00000%> (+5.88235%) ⬆️
...ug-ins/Argo/Repositories/ArgoMetadataRepository.cs 79.06977% <0.00000%> (+9.30233%) ⬆️
src/TaskManager/API/MetadataRepositoryBase.cs 50.00000% <0.00000%> (+38.88889%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e2abd...ba15afa. Read the comment docs.

Signed-off-by: RemakingEden <joss.sparkes@gmail.com>
@RemakingEden RemakingEden changed the title Added a hook to remove all task dispatch events after each test Remove flaky test Sep 8, 2022
@RemakingEden RemakingEden force-pushed the jsparkes/fix-flake-int-test branch from 3b51ba8 to ba15afa Compare September 8, 2022 14:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RemakingEden RemakingEden merged commit ed22a80 into develop Sep 8, 2022
@RemakingEden RemakingEden deleted the jsparkes/fix-flake-int-test branch September 8, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants