Skip to content

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 14, 2022

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes #403

Fixes the Patient name within the DICOM

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #419 (8e760ba) into develop (6642896) will increase coverage by 0.10518%.
The diff coverage is 77.77778%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #419         +/-   ##
===================================================
+ Coverage   58.88483%   58.99001%   +0.10517%     
===================================================
  Files            135         135                 
  Lines          16697       16713         +16     
  Branches        1732        1734          +2     
===================================================
+ Hits            9832        9859         +27     
+ Misses          6558        6543         -15     
- Partials         307         311          +4     
Flag Coverage Δ
unittests 58.99001% <77.77778%> (+0.10517%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/WorkflowManager/Storage/Services/DicomService.cs 44.75524% <76.92308%> (+11.68437%) ⬆️
...tTests/Storage.Tests/Services/DicomServiceTests.cs 100.00000% <100.00000%> (ø)
...vices/DataRetentionService/DataRetentionService.cs 94.11765% <0.00000%> (+2.94118%) ⬆️
...ins/AideClinicalReview/AideClinicalReviewPlugin.cs 80.00000% <0.00000%> (+3.47826%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6642896...8e760ba. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.5% 82.5% Coverage
0.0% 0.0% Duplication

@jackschofield23 jackschofield23 marked this pull request as ready for review September 14, 2022 13:02
Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackschofield23 jackschofield23 merged commit 871ad6c into develop Sep 15, 2022
@jackschofield23 jackschofield23 deleted the patient-name-fix branch September 15, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patient name is an object rather than a string

2 participants